Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: presubmit_canned_checks.py

Issue 6948006: Move copyright and svn mime check presubmit checks to trigger on commit only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index d6b31ce13d4f5c4897fd1377c5fb9eb42ecc3b60..c62caf5a64b99f3c496ec8d5f22be4cf99649724 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -939,17 +939,21 @@ def PanProjectChecks(input_api, output_api,
snapshot("checking eol style")
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
- snapshot("checking svn mime types")
- results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
- input_api, output_api))
- snapshot("checking license")
- results.extend(input_api.canned_checks.CheckLicense(
- input_api, output_api, license_header, source_file_filter=sources))
snapshot("checking nsobjects")
results.extend(_CheckConstNSObject(
input_api, output_api, source_file_filter=sources))
snapshot("checking singletons")
results.extend(_CheckSingletonInHeaders(
input_api, output_api, source_file_filter=sources))
+
+ # The following checks are only done on commit, since the commit bot will
+ # auto-fix most of these.
+ if input_api.is_committing:
+ snapshot("checking svn mime types")
+ results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
+ input_api, output_api))
+ snapshot("checking license")
+ results.extend(input_api.canned_checks.CheckLicense(
+ input_api, output_api, license_header, source_file_filter=sources))
snapshot("done")
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698