Include full redirect chain in downloads safebrowsing ping.

chrome/browser/safe_browsing/safe_browsing_service.h

Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 85a7f9fe5d6df6abf0a41694536ee3d1894167aa..e612633bf5c06e7e99567bfa59db09b94e47d2fb 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -247,14 +247,21 @@ class SafeBrowsingService
   // protocol buffer, so the service can send it over.
   virtual void SendSerializedMalwareDetails(const std::string& serialized);
 
-  // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
-  // to the server. Can only be called on UI thread.
+  // Report hits to the unsafe contents (malware, phishing) to the server. Can
+  // only be called on UI thread.
   void ReportSafeBrowsingHit(const GURL& malicious_url,
                              const GURL& page_url,
                              const GURL& referrer_url,
                              bool is_subresource,
                              UrlCheckResult threat_type);

[noelutz, 2011/05/06 04:24:12]

Have you considered renaming this method to something like
ReportSafeBrowsingHitWithData or simply adding a POST data parameter to this
function?  Note: on the server side I implemented a generic way to support pings
that contain any post data.  The server code is not specific to bad binary hits.

This approach might help to get rid of some of the code duplication.

[mattm, 2011/05/10 02:26:09]

I like it.  done.

 
+  // Report hits to unsafe downloads to the server. Can only be called on UI
+  // thread.
+  void ReportSafeBrowsingHitWithChain(const std::vector<GURL>& url_chain,
+                                      const GURL& referrer_url,
+                                      bool is_subresource,
+                                      UrlCheckResult threat_type);
+
  protected:
   // Creates the safe browsing service.  Need to initialize before using.
   SafeBrowsingService();
@@ -369,6 +376,13 @@ class SafeBrowsingService
                                        bool is_subresource,
                                        UrlCheckResult threat_type);
 
+  // Call protocol manager on IO thread to report hits of unsafe contents.
+  void ReportSafeBrowsingHitWithChainOnIOThread(
+      const std::vector<GURL>& url_chain,
+      const GURL& referrer_url,
+      bool is_subresource,
+      SafeBrowsingService::UrlCheckResult threat_type);
+
   // Checks the download hash on safe_browsing_thread_.
   void CheckDownloadHashOnSBThread(SafeBrowsingCheck* check);