Include full redirect chain in downloads safebrowsing ping.

chrome/browser/safe_browsing/safe_browsing_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #pragma once
@@ skipping 229 matching lines @@
   // Log the user perceived delay caused by SafeBrowsing. This delay is the time
   // delta starting from when we would have started reading data from the
   // network, and ending when the SafeBrowsing check completes indicating that
   // the current page is 'safe'.
   void LogPauseDelay(base::TimeDelta time);
 
   // Called on the IO thread by the MalwareDetails with the serialized
   // protocol buffer, so the service can send it over.
   virtual void SendSerializedMalwareDetails(const std::string& serialized);
 
-  // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
-  // to the server. Can only be called on UI thread.
+  // Report hits to the unsafe contents (malware, phishing) to the server. Can
+  // only be called on UI thread.
   void ReportSafeBrowsingHit(const GURL& malicious_url,
                              const GURL& page_url,
                              const GURL& referrer_url,
                              bool is_subresource,
                              UrlCheckResult threat_type);

[noelutz, 2011/05/06 04:24:12]

Have you considered renaming this method to something like
ReportSafeBrowsingHitWithData or simply adding a POST data parameter to this
function?  Note: on the server side I implemented a generic way to support pings
that contain any post data.  The server code is not specific to bad binary hits.

This approach might help to get rid of some of the code duplication.

[mattm, 2011/05/10 02:26:09]

I like it.  done.

 
+  // Report hits to unsafe downloads to the server. Can only be called on UI
+  // thread.
+  void ReportSafeBrowsingHitWithChain(const std::vector<GURL>& url_chain,
+                                      const GURL& referrer_url,
+                                      bool is_subresource,
+                                      UrlCheckResult threat_type);
+
  protected:
   // Creates the safe browsing service.  Need to initialize before using.
   SafeBrowsingService();
 
   virtual ~SafeBrowsingService();
 
  private:
   friend class SafeBrowsingServiceFactoryImpl;
 
   typedef std::set<SafeBrowsingCheck*> CurrentChecks;
@@ skipping 94 matching lines @@
   // Invoked on the UI thread to show the blocking page.
   void DoDisplayBlockingPage(const UnsafeResource& resource);
 
   // Call protocol manager on IO thread to report hits of unsafe contents.
   void ReportSafeBrowsingHitOnIOThread(const GURL& malicious_url,
                                        const GURL& page_url,
                                        const GURL& referrer_url,
                                        bool is_subresource,
                                        UrlCheckResult threat_type);
 
+  // Call protocol manager on IO thread to report hits of unsafe contents.
+  void ReportSafeBrowsingHitWithChainOnIOThread(
+      const std::vector<GURL>& url_chain,
+      const GURL& referrer_url,
+      bool is_subresource,
+      SafeBrowsingService::UrlCheckResult threat_type);
+
   // Checks the download hash on safe_browsing_thread_.
   void CheckDownloadHashOnSBThread(SafeBrowsingCheck* check);
 
   // Invoked by CheckDownloadUrl. It checks the download URL on
   // safe_browsing_thread_.
   void CheckDownloadUrlOnSBThread(SafeBrowsingCheck* check);
 
   // The callback function when a safebrowsing check is timed out. Client will
   // be notified that the safebrowsing check is SAFE when this happens.
   void TimeoutCallback(SafeBrowsingCheck* check);
@@ skipping 83 matching lines @@
 class SafeBrowsingServiceFactory {
  public:
   SafeBrowsingServiceFactory() { }
   virtual ~SafeBrowsingServiceFactory() { }
   virtual SafeBrowsingService* CreateSafeBrowsingService() = 0;
  private:
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingServiceFactory);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_