Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 6933009: Fix overflow in arm simulator. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix overflow in arm simulator. Don't copy 64 bits to a 32 bit value. R=karlklose@chromium.org,sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7788

Patch Set 1 #

Patch Set 2 : Safer use of typeof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/arm/simulator-arm.cc View 1 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-04 17:16:58 UTC) #1
Karl Klose
LGTM.
9 years, 7 months ago (2011-05-05 05:52:45 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-05 06:23:42 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698