Issue 6928021: Make ViewHostMsg_Keygen a routed ipc (part 1/2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6928021: Make ViewHostMsg_Keygen a routed ipc (part 1/2). (Closed)

Created:
9 years, 7 months ago by mattm

Modified:
8 years, 2 months ago

Reviewers:
jam

CC:
chromium-reviews, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make ViewHostMsg_Keygen a routed ipc (part 1/2). Add signedPublicKeyAndChallengeString to RenderView. Required before https://bugs.webkit.org/show_bug.cgi?id=60232 can be landed. BUG=42073 TEST=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unnecessary WebKit::s #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
M	content/common/view_messages.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	content/renderer/render_view.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/render_view.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitclient_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years, 7 months ago (2011-05-06 03:20:09 UTC) #2

lgtm

http://codereview.chromium.org/6928021/diff/1/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/6928021/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:2801: const WebKit::WebString& challenge,
nit: drop the WebKit:: here and below

Expand Messages | Collapse Messages