Trying to re-land http://codereview.chromium.org/6901141.

Trying to re-land http://codereview.chromium.org/6901141.

Changes from previus revision:
- Made my own strncpy in I18NUtils class (we can't use OS::SNPrintF nor snprintf).
- Fixed a crashing bug related to ICU call in LanguageMatcher::BCP47ToICUFormat.

TEST=Visit i18n.kaziprst.org/locale.html
Committed: http://code.google.com/p/v8/source/detail?r=7796

[Nebojša Ćirić, 2011-05-04 21:05:50]

Soren Gjesse:
Previous commit was reverted because it was breaking Windows bots. I removed all
OS::SNPrintF calls and replaced them with my StrNCopy that uses strncpy which
should be cross platform compatible.
Is this acceptable?

Jungshik:
I fortified the BCP47ToICUFormat method to not crash with long extensions. I
also simplified some logic in the call chain but nothing else changed since the
last review.

[jungshik at Google, 2011-05-04 22:45:47]

LGTM

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/i18n-utils.cc (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/i18n-utils.cc:40: dest[length - 1] = '\0';
Effectively, you copy at most |length -1| bytes, don't you? Pls, update the
comment in the header accordingly.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/i18n.js:52: this.icuLocaleID_ =
properties.icuLocaleID;
Is adding '_' at the end "prominent enough" to tell that it's internal? I'm just
wondering if '__icuLocaleID__' would be a better (widely used) convention?

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/language-matcher.cc (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:136: if (*is_ascii == NULL)
return false;
nit: ascii_value?

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:201: // We need to check if
extension part of language id conforms to the length.
Can you add a URL  to the bug you just filed? Thanks.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:205: // Truncate to get
non-crashing string, but still preserve base language.
How about truncating at the last logical boundary before going over the limit?
Well, perhaps, it's not worth the trouble. If you don't want to do that, you may
want to note that here.

[Nebojša Ćirić, 2011-05-04 23:09:40]

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/i18n-utils.cc (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/i18n-utils.cc:40: dest[length - 1] = '\0';
On 2011/05/04 22:45:47, Jungshik Shin wrote:
> Effectively, you copy at most |length -1| bytes, don't you? Pls, update the
> comment in the header accordingly.

Done.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/i18n.js:52: this.icuLocaleID_ =
properties.icuLocaleID;
On 2011/05/04 22:45:47, Jungshik Shin wrote:
> Is adding '_' at the end "prominent enough" to tell that it's internal? I'm
just
> wondering if '__icuLocaleID__' would be a better (widely used) convention? 

Done.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
File src/extensions/experimental/language-matcher.cc (right):

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:136: if (*is_ascii == NULL)
return false;
On 2011/05/04 22:45:47, Jungshik Shin wrote:
> nit: ascii_value? 

Done.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:201: // We need to check if
extension part of language id conforms to the length.
On 2011/05/04 22:45:47, Jungshik Shin wrote:
> Can you add a URL  to the bug you just filed? Thanks. 

Done.

http://codereview.chromium.org/6928017/diff/2003/src/extensions/experimental/...
src/extensions/experimental/language-matcher.cc:205: // Truncate to get
non-crashing string, but still preserve base language.
I've calculated the length of the base language and cutting there, removing
extension completely.

On 2011/05/04 22:45:47, Jungshik Shin wrote:
> How about truncating at the last logical boundary before going over the limit?
> Well, perhaps, it's not worth the trouble. If you don't want to do that, you
may
> want to note that here.