Issue 6927058: Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState (ui/gfx/scoped_ns_graphics_context_st...

Issue 6927058: Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState (ui/gfx/scoped_ns_graphics_context_st... (Closed)

Created:
9 years, 7 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, darin-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/742/src/

Visibility:
Public.

Description

Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState (ui/gfx/scoped_ns_graphics_context_state_mac.h). BUG=none TEST=covered by tests Review URL: http://codereview.chromium.org/6904026 TBR=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84309

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -114 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm	View	4 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/dock_icon.mm	View	3 chunks	+21 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_cell.mm	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/browser_action_button.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar/find_bar_view.mm	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/cocoa/gradient_button_cell.mm	View	7 chunks	+20 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/instant_opt_in_view.mm	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/styled_text_field_cell.mm	View	3 chunks	+2 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_view.mm	View	7 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell.mm	View	2 chunks	+2 lines, -3 lines	0 comments	Download
A +	ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/ui_gfx.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

apparently my shadow fix depended on this On Thu, May 5, 2011 at 1:54 PM, ...

9 years, 7 months ago (2011-05-05 20:56:01 UTC) #2

Robert Sesek

9 years, 7 months ago (2011-05-05 20:58:05 UTC) #3

This makes me uncomfortable. Can't you just change the shadow fix to the
manual way for the merge?

rsesek / @chromium.org

On Thu, May 5, 2011 at 4:55 PM, Nico Weber <thakis@chromium.org> wrote:

> apparently my shadow fix depended on this
>
> On Thu, May 5, 2011 at 1:54 PM,  <thakis@chromium.org> wrote:
> > Reviewers: rsesek,
> >
> > Description:
> > Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState
> > (ui/gfx/scoped_ns_graphics_context_state_mac.h).
> >
> > BUG=none
> > TEST=covered by tests
> >
> >
> > Review URL: http://codereview.chromium.org/6904026
> >
> > TBR=rsesek@chromium.org
> >
> > Please review this at http://codereview.chromium.org/6927058/
> >
> > SVN Base: svn://svn.chromium.org/chrome/branches/742/src/
> >
> > Affected files:
> >  M     chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
> >  M     chrome/browser/renderer_host/render_widget_host_view_mac.mm
> >  M     chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm
> >  M     chrome/browser/ui/cocoa/browser_window_controller.mm
> >  M     chrome/browser/ui/cocoa/dock_icon.mm
> >  M     chrome/browser/ui/cocoa/download/download_item_cell.mm
> >  M     chrome/browser/ui/cocoa/extensions/browser_action_button.mm
> >  M     chrome/browser/ui/cocoa/find_bar/find_bar_view.mm
> >  M     chrome/browser/ui/cocoa/gradient_button_cell.mm
> >  M     chrome/browser/ui/cocoa/location_bar/
> content_setting_decoration.mm
> >  M     chrome/browser/ui/cocoa/location_bar/instant_opt_in_view.mm
> >  M     chrome/browser/ui/cocoa/styled_text_field_cell.mm
> >  M     chrome/browser/ui/cocoa/tabs/tab_view.mm
> >  M     chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell.mm
> >  A  +  ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h
> >  A  +  ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm
> >  M     ui/ui_gfx.gypi
> >
> >
> >
>

Expand Messages | Collapse Messages