Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/ui/cocoa/dock_icon.mm

Issue 6927058: Merge 83125 - Add and use gfx::ScopedNSGraphicsContextState (ui/gfx/scoped_ns_graphics_context_st... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/742/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/dock_icon.mm
===================================================================
--- chrome/browser/ui/cocoa/dock_icon.mm (revision 84308)
+++ chrome/browser/ui/cocoa/dock_icon.mm (working copy)
@@ -5,6 +5,7 @@
#import "chrome/browser/ui/cocoa/dock_icon.h"
#include "base/memory/scoped_nsobject.h"
+#include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
// The fraction of the size of the dock icon that the badge is.
static const float kBadgeFraction = 0.4f;
@@ -77,14 +78,15 @@
[[NSGradient alloc] initWithStartingColor:backgroundHighlight
endingColor:backgroundColor]);
NSBezierPath* badgeEdge = [NSBezierPath bezierPathWithOvalInRect:badgeRect];
- [NSGraphicsContext saveGraphicsState];
- [badgeEdge addClip];
- [backgroundGradient drawFromCenter:badgeCenter
- radius:0.0
- toCenter:badgeCenter
- radius:badgeRadius
- options:0];
- [NSGraphicsContext restoreGraphicsState];
+ {
+ gfx::ScopedNSGraphicsContextSaveGState scopedGState;
+ [badgeEdge addClip];
+ [backgroundGradient drawFromCenter:badgeCenter
+ radius:0.0
+ toCenter:badgeCenter
+ radius:badgeRadius
+ options:0];
+ }
// Slice
if (!indeterminate_) {
@@ -114,26 +116,26 @@
clockwise:YES];
[progressSlice closePath];
}
- [NSGraphicsContext saveGraphicsState];
+ gfx::ScopedNSGraphicsContextSaveGState scopedGState;
[progressSlice addClip];
[sliceGradient drawFromCenter:badgeCenter
radius:0.0
toCenter:badgeCenter
radius:badgeRadius
options:0];
- [NSGraphicsContext restoreGraphicsState];
}
// Edge
- [NSGraphicsContext saveGraphicsState];
- [[NSColor whiteColor] set];
- scoped_nsobject<NSShadow> shadow([[NSShadow alloc] init]);
- [shadow.get() setShadowOffset:NSMakeSize(0, -2)];
- [shadow setShadowBlurRadius:2];
- [shadow set];
- [badgeEdge setLineWidth:2];
- [badgeEdge stroke];
- [NSGraphicsContext restoreGraphicsState];
+ {
+ gfx::ScopedNSGraphicsContextSaveGState scopedGState;
+ [[NSColor whiteColor] set];
+ scoped_nsobject<NSShadow> shadow([[NSShadow alloc] init]);
+ [shadow.get() setShadowOffset:NSMakeSize(0, -2)];
+ [shadow setShadowBlurRadius:2];
+ [shadow set];
+ [badgeEdge setLineWidth:2];
+ [badgeEdge stroke];
+ }
// Download count
scoped_nsobject<NSNumberFormatter> formatter(
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/download/download_item_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698