Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 6927001: Merge 84005 - Mac. Ensure no more than one visibly selected item in each bookmark folder menu. (Closed)

Created:
9 years, 7 months ago by mafv
Modified:
9 years, 6 months ago
Reviewers:
mafv
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Merge 84005 - Mac. Ensure no more than one visibly selected item in each bookmark folder menu. Make the BookmarkBarFolderButtonCell not hover select itself (by overriding setMouseInside to do nothing). Instead have the controller manage the selection, which enables selection to be moved from the keyboard or mouse without two selections appearing. Remove the [BookmarkBarFolderController toggleButtonBorderingWhileMouseInside] hack which was only necessary because of a bug in [GradientButtonCell updateTrackingAreas] that unexpectedly changed the isMouseInside_ state. Add new logic to [BookmarkBarFolderController performOneScroll] to make it detect an existing mouse-initiated selection. If one is present before scroll it will select whatever item ends up under the mouse after the scroll. Otherwise no selection change will happen, which is right. BUG=75014, 77676, 80043, 81072, 46595 Review URL: http://codereview.chromium.org/6889025 TBR=maf@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -41 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 6 chunks +66 lines, -38 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mafv
9 years, 7 months ago (2011-05-04 01:14:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698