Issue 6889025: Mac. Ensure no more than one visibly selected item in each bookmark folder menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6889025: Mac. Ensure no more than one visibly selected item in each bookmark folder menu. (Closed)

Created:
9 years, 7 months ago by mafv

Modified:
9 years, 6 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Mac. Ensure no more than one visibly selected item in each bookmark folder menu. Make the BookmarkBarFolderButtonCell not hover select itself (by overriding setMouseInside to do nothing). Instead have the controller manage the selection, which enables selection to be moved from the keyboard or mouse without two selections appearing. Remove the [BookmarkBarFolderController toggleButtonBorderingWhileMouseInside] hack which was only necessary because of a bug in [GradientButtonCell updateTrackingAreas] that unexpectedly changed the isMouseInside_ state. Add new logic to [BookmarkBarFolderController performOneScroll] to make it detect an existing mouse-initiated selection. If one is present before scroll it will select whatever item ends up under the mouse after the scroll. Otherwise no selection change will happen, which is right. BUG=75014, 77676, 80043, 81072, 46595 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84005

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -38 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm	View	3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View	1 2 3 4	6 chunks	+66 lines, -35 lines	0 comments	Download
M	chrome/browser/ui/cocoa/gradient_button_cell.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/gradient_button_cell.mm	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 6889025: Mac. Ensure no more than one visibly selected item in each bookmark folder menu. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages