Issue 6914029: We assume that each SkDevice is our custom PlatformDevice. This assumption is not valid when usin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6914029: We assume that each SkDevice is our custom PlatformDevice. This assumption is not valid when usin... (Closed)

Created:
9 years, 7 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
Jeff Timanus, sky, reed1

CC:
chromium-reviews, Vangelis Kokkevis

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

We assume that each SkDevice is our custom PlatformDevice. This assumption is not valid when using skia gpu path. This patch adds a "bool" meta-data to our custom PlatformDevice to properly identify them before performing the cast. This is a temporary hack for me to move forward with the gpu path. twiz@ is working on a long term solution that eliminates the need for subclassing SkDevice. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86867

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ui/gfx/native_theme_win.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jeff Timanus

9 years, 7 months ago (2011-05-04 21:22:47 UTC) #4

LGTM

http://codereview.chromium.org/6914029/diff/1/skia/ext/platform_canvas.cc
File skia/ext/platform_canvas.cc (right):

http://codereview.chromium.org/6914029/diff/1/skia/ext/platform_canvas.cc#new...
skia/ext/platform_canvas.cc:12: static const char* kPlatformDeviceIdentifier =
"CrPlatformDevice";
Style guide nit/question.  Does static have any meaning in an unnamed
named-space in a .cc translation unit?

Expand Messages | Collapse Messages