Issue 6913008: CHROMIUM: gobi: Remove worker.exit hack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6913008: CHROMIUM: gobi: Remove worker.exit hack. (Closed)

Created:
9 years, 7 months ago by Elly Fong-Jones

Modified:
9 years, 4 months ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Olof Johansson, sleffler+cc_chromium.org, msb+croskernel_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/kernel.git@0.12.433.B

Visibility:
Public.

CHROMIUM: gobi: Remove worker.exit hack. The exit member was added to hack around crosbug.com/14190, but we need a proper fix. I discussed with olofj, and we think the right thing is to use a waitqueue and wait for there to be work available or for the thread to be asked to exit. BUG=chromium-os:14205 TEST=Adhoc Build, modem status, suspend/resume Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Signed-off-by: Olof Johansson <olofj@chromium.org>; Change-Id: Ic1a990d6ab71861031a7c9149df3dcfef3b11111 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c69b798 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bda178a

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -31 lines)			Patch
	M	drivers/net/usb/gobi/qcusbnet.c	View		10 chunks	+45 lines, -29 lines	0 comments	Download
	M	drivers/net/usb/gobi/structs.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

LGTM