Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 6906001: Protect against image conversion failure in mac::FaviconForTabContents(). (Closed)

Created:
9 years, 8 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Protect against image conversion failure in mac::FaviconForTabContents(). BUG=80579 TEST=Monitor crash server. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83056

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comment nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/tab_contents/favicon_util.mm View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Scott Hess - ex-Googler
Actual code and placement LGTM. Note that up in [HungRendererController showForTabContents:], there is an explicit ...
9 years, 8 months ago (2011-04-26 17:55:34 UTC) #1
Scott Hess - ex-Googler
BTW, BUG=80579 TEST=Monitor crash server.
9 years, 8 months ago (2011-04-26 17:56:42 UTC) #2
Robert Sesek
On 2011/04/26 17:55:34, shess wrote: > Note that up in [HungRendererController showForTabContents:], there is an ...
9 years, 8 months ago (2011-04-26 18:08:51 UTC) #3
Scott Hess - ex-Googler
lgtm.
9 years, 8 months ago (2011-04-26 18:26:04 UTC) #4
commit-bot: I haz the power
9 years, 8 months ago (2011-04-26 19:30:57 UTC) #5
Change committed as 83056

Powered by Google App Engine
This is Rietveld 408576698