Protect against image conversion failure in mac::FaviconForTabContents().

chrome/browser/ui/cocoa/tab_contents/favicon_util.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/tab_contents/favicon_util.h"
 
 #import <AppKit/AppKit.h>
 
 #include "app/mac/nsimage_cache.h"
 #include "base/mac/mac_util.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "skia/ext/skia_utils_mac.h"
 
 namespace mac {
 
 NSImage* FaviconForTabContents(TabContents* contents) {
   // TabContents returns IDR_DEFAULT_FAVICON, which is a rasterized version of
   // the Mac PDF. Use the PDF so the icon in the Omnibox matches the default
   // favicon.
   if (contents && contents->FaviconIsValid()) {
     CGColorSpaceRef color_space = base::mac::GetSystemColorSpace();
-    return gfx::SkBitmapToNSImageWithColorSpace(contents->GetFavicon(),
-                                                color_space);
+    NSImage* image =
+        gfx::SkBitmapToNSImageWithColorSpace(contents->GetFavicon(),
+                                             color_space);
+    // The |image| could be nil if the conversion failed. In that case, fallback
+    // to the default image.

[Scott Hess - ex-Googler, 2011/04/26 17:55:34]

AFAICT, the only way it returns nil is if skiaBitmap.isNull().  So I'm not sure
about this comment.

[Robert Sesek, 2011/04/26 18:08:51]

I wrote the comment from memory, but you're right. Updated the comment.

+    if (image) {
+      return image;
+    }

[Scott Hess - ex-Googler, 2011/04/26 17:55:34]

Is it just me, or do those {} look extraneous?

[Robert Sesek, 2011/04/26 18:08:51]

I like extraneous braces in this instance because of the weird wrapping
whitespace above and to make the scope indentation clear with the closing brace
below.

   }
 
   return app::mac::GetCachedImageWithName(@"nav.pdf");
 }
 
 }  // namespace mac