chrome/browser/download/download_shelf_context_menu.cc - Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_context_menu.cc

Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Check |file_externally_removed_| at DownloadItem::CanOpenDownload() Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/download/download_util.cc » ('j') | chrome/browser/resources/downloads.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_shelf_context_menu.cc

diff --git a/chrome/browser/download/download_shelf_context_menu.cc b/chrome/browser/download/download_shelf_context_menu.cc

index d019d7a17589b89e2d29ba8e3cf79ff8dccef442..25fdb86e27172f214c9a757a4904e357c7e16266 100644

--- a/chrome/browser/download/download_shelf_context_menu.cc

+++ b/chrome/browser/download/download_shelf_context_menu.cc

@@ -26,7 +26,7 @@ bool DownloadShelfContextMenu::IsCommandIdEnabled(int command_id) const {

switch (command_id) {

case SHOW_IN_FOLDER:

case OPEN_WHEN_COMPLETE:

- return !download_item_->IsCancelled();

+ return download_item_->CanShowInFolder();

case ALWAYS_OPEN_TYPE:

return download_item_->CanOpenDownload();

case CANCEL:

@@ -41,7 +41,7 @@ bool DownloadShelfContextMenu::IsCommandIdEnabled(int command_id) const {

bool DownloadShelfContextMenu::IsCommandIdChecked(int command_id) const {

switch (command_id) {

case OPEN_WHEN_COMPLETE:

- return download_item_->open_when_complete();

+ return download_item_->CanShowInFolder();

Randy Smith (Not in Mondays) 2011/06/08 22:07:54 This looks wrong to me--why should the open when c

haraken1 2011/06/09 05:25:55 You are right. I fixed it.

case ALWAYS_OPEN_TYPE:

return download_item_->ShouldOpenFileBasedOnExtension();

case TOGGLE_PAUSE:

« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/download/download_util.cc » ('j') | chrome/browser/resources/downloads.js » ('J')