Detect removed files and reflect the state in chrome://downloads and the download shelf

chrome/browser/download/download_shelf_context_menu.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_shelf_context_menu.h"
 
 #include "chrome/browser/download/download_item.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 DownloadShelfContextMenu::~DownloadShelfContextMenu() {}
 
 DownloadShelfContextMenu::DownloadShelfContextMenu(
     BaseDownloadItemModel* download_model)
     : download_model_(download_model),
       download_item_(download_model->download()) {
 }
 
 ui::SimpleMenuModel* DownloadShelfContextMenu::GetMenuModel() {
   return download_item_->IsComplete() ? GetFinishedMenuModel()
                                       : GetInProgressMenuModel();
 }
 
 bool DownloadShelfContextMenu::IsCommandIdEnabled(int command_id) const {
   switch (command_id) {
     case SHOW_IN_FOLDER:
     case OPEN_WHEN_COMPLETE:
-      return !download_item_->IsCancelled();
+      return download_item_->CanShowInFolder();
     case ALWAYS_OPEN_TYPE:
       return download_item_->CanOpenDownload();
     case CANCEL:
       return download_item_->IsPartialDownload();
     case TOGGLE_PAUSE:
       return download_item_->IsInProgress();
     default:
       return command_id > 0 && command_id < MENU_LAST;
   }
 }
 
 bool DownloadShelfContextMenu::IsCommandIdChecked(int command_id) const {
   switch (command_id) {
     case OPEN_WHEN_COMPLETE:
-      return download_item_->open_when_complete();
+      return download_item_->CanShowInFolder();

[Randy Smith (Not in Mondays), 2011/06/08 22:07:54]

This looks wrong to me--why should the open when complete flag be set in the UI
based on CanShowInFolder?

[haraken1, 2011/06/09 05:25:55]

You are right. I fixed it. 

     case ALWAYS_OPEN_TYPE:
       return download_item_->ShouldOpenFileBasedOnExtension();
     case TOGGLE_PAUSE:
       return download_item_->is_paused();
   }
   return false;
 }
 
 void DownloadShelfContextMenu::ExecuteCommand(int command_id) {
   switch (command_id) {
@@ skipping 90 matching lines @@
       ALWAYS_OPEN_TYPE, IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE);
   finished_download_menu_model_->AddSeparator();
   finished_download_menu_model_->AddItemWithStringId(
       SHOW_IN_FOLDER, IDS_DOWNLOAD_MENU_SHOW);
   finished_download_menu_model_->AddSeparator();
   finished_download_menu_model_->AddItemWithStringId(
       CANCEL, IDS_DOWNLOAD_MENU_CANCEL);
 
   return finished_download_menu_model_.get();
 }