chrome/browser/download/download_util.cc - Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_util.cc

Issue 6905049: Detect removed files and reflect the state in chrome://downloads and the download shelf (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Correct typo Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_manager_unittest.cc ('K') | « chrome/browser/download/download_shelf.cc ('k') | chrome/browser/resources/downloads.html » ('j') | chrome/browser/resources/downloads.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_util.cc

diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc

index 72a0b92176a75a9d30106a08755e7c12ca0e4f01..b71bc7f3bc5eff4c26fdb0de7fa4b739124a240e 100644

--- a/chrome/browser/download/download_util.cc

+++ b/chrome/browser/download/download_util.cc

@@ -662,7 +662,9 @@ DictionaryValue* CreateDownloadItemValue(DownloadItem* download, int id) {

} else if (download->IsCancelled()) {

file_value->SetString("state", "CANCELLED");

} else if (download->IsComplete()) {

- if (download->safety_state() == DownloadItem::DANGEROUS) {

+ if (!download->file_exists()) {

+ file_value->SetString("state", "REMOVED");

+ } else if (download->safety_state() == DownloadItem::DANGEROUS) {

file_value->SetString("state", "DANGEROUS");

} else {

file_value->SetString("state", "COMPLETE");