Detect removed files and reflect the state in chrome://downloads and the download shelf

chrome/browser/resources/downloads.html

Index: chrome/browser/resources/downloads.html
diff --git a/chrome/browser/resources/downloads.html b/chrome/browser/resources/downloads.html
index 97952fb100f85921057740fafdb1cd68970fc648..912d8ab7effa831de8eb1b01675c46baa1451020 100644
--- a/chrome/browser/resources/downloads.html
+++ b/chrome/browser/resources/downloads.html
@@ -463,6 +463,7 @@ Download.States = {
   IN_PROGRESS : "IN_PROGRESS",
   CANCELLED : "CANCELLED",
   COMPLETE : "COMPLETE",
+  REMOVED : "REMOVED",
   PAUSED : "PAUSED",
   DANGEROUS : "DANGEROUS",
   INTERRUPTED : "INTERRUPTED",
@@ -499,7 +500,10 @@ Download.prototype.update = function(download) {
   this.filePath_ = download.file_path;
   this.fileName_ = download.file_name;
   this.url_ = download.url;
-  this.state_ = download.state;
+  // This code is tricky and is not so good. See issue 6905049 for more details.

[Paweł Hajdan Jr., 2011/05/13 08:41:10]

No no, I think we have enough hacks in the download code and don't need another
one. We can have a separate discussion how to deal with it the best way (thanks
for explaining the issue in detail).

Can we just introduce a "don't know" or "updating" state?

Please note that the bug for this CL is Mstone-X, i.e. not a priority. I'd
rather postpone this patch than make the download code more messy.

[haraken1, 2011/05/13 14:08:17]

I would like to postpone to fix this hack. As Randy advised, I filed this issue
as a bug and referred the bug number in the comment.

[Randy Smith (Not in Mondays), 2011/05/13 20:45:32]

haraken: I'm afraid I want to support Pawel on this.  I tend to bias towards
letting people contribute, but his comment's reminded me that that decision
needs to be tempered by the priority of the fix and the nature of the code.  
And he's quite right that we have a lot of hacks and need to be moving towards
cleaning the code up.

Would it be possible to keep the updates in the downloads.html file FIFO?  I.e.
if new updates come in (e.g. because the file has been REMOVED) to put it at the
end of the list that's being processed in 50ms chunks?  

+  if (this.state_ != Download.States.REMOVED) {
+    this.state_ = download.state;
+  }
   this.dangerType_ = download.danger_type;
 
   this.since_ = download.since_string;
@@ -617,6 +621,8 @@ Download.prototype.getStatusText_ = function() {
       return this.progressStatusText_;
     case Download.States.CANCELLED:
       return localStrings.getString('status_cancelled');
+    case Download.States.REMOVED:
+      return localStrings.getString('status_removed');
     case Download.States.PAUSED:
       return localStrings.getString('status_paused');
     case Download.States.DANGEROUS: