Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Use JSON.parse instead of eval for the debugger JSON protocol. R=sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7748

Patch Set 2 : Address comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
M	src/debug-debugger.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	test/mjsunit/debug-evaluate.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/mjsunit/debug-scripts-request.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6903172/diff/1/test/mjsunit/debug-scripts-request.js File test/mjsunit/debug-scripts-request.js (left): http://codereview.chromium.org/6903172/diff/1/test/mjsunit/debug-scripts-request.js#oldcode74 test/mjsunit/debug-scripts-request.js:74: testArguments(dcp, '{"types":0xFF}', true); 255 instead of deleting this ...

9 years, 7 months ago (2011-05-02 14:07:09 UTC) #2

Mads Ager (chromium)

9 years, 7 months ago (2011-05-02 14:19:15 UTC) #3

http://codereview.chromium.org/6903172/diff/1/test/mjsunit/debug-scripts-requ...
File test/mjsunit/debug-scripts-request.js (left):

http://codereview.chromium.org/6903172/diff/1/test/mjsunit/debug-scripts-requ...
test/mjsunit/debug-scripts-request.js:74: testArguments(dcp, '{"types":0xFF}',
true);
On 2011/05/02 14:07:09, Søren Gjesse wrote:
> 255 instead of deleting this line?

Done.

Expand Messages | Collapse Messages

Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments #

Messages