src/debug-debugger.js - Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug-debugger.js

Issue 6903172: Use JSON.parse instead of eval for the debugger JSON protocol. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug-debugger.js

diff --git a/src/debug-debugger.js b/src/debug-debugger.js

index bc0f966fb198195a40d2aeeaab8fc16a33552ec6..908fcd2120ffa8cafe61fb959a8fa007aeadd855 100644

--- a/src/debug-debugger.js

+++ b/src/debug-debugger.js

@@ -1335,7 +1335,7 @@ DebugCommandProcessor.prototype.processDebugJSONRequest = function(json_request)

try {

// Convert the JSON string to an object.

- request = %CompileString('(' + json_request + ')')();

+ request = JSON.parse(json_request);

// Create an initial response.

response = this.createResponse(request);

« no previous file with comments | « no previous file | test/cctest/test-debug.cc » ('j') | no next file with comments »