Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 6901003: Revert my recent changes regarding title directionality. (Closed)

Created:
9 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, brettw-cc_chromium.org, kkania, Avi (use Gerrit), pam+watch_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Revert my recent changes regarding title directionality. This reverts: r82400: Plumb direction of document title through IPC layer. r82582: Add and use a base::i18n::StringWithDirection for carrying titles. r82778: Change NavigationEntry's title fields to carry the text direction. I'm going to take an alternative approach; after getting this far, I can see that this approach was too complicated. BUG=27094 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82908

Patch Set 1 #

Patch Set 2 : copyrights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -239 lines) Patch
M base/i18n/rtl.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.h View 8 chunks +9 lines, -11 lines 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 3 chunks +5 lines, -11 lines 0 comments Download
M content/browser/tab_contents/navigation_entry_unittest.cc View 1 4 chunks +15 lines, -23 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 6 chunks +6 lines, -12 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 7 chunks +12 lines, -29 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view.cc View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
Sorry to pick on you, but you responded to the thread... :)
9 years, 8 months ago (2011-04-25 18:09:29 UTC) #1
brettw
9 years, 8 months ago (2011-04-25 19:27:41 UTC) #2
LGTM rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698