chrome/browser/external_tab_container_win.cc - Issue 6901003: Revert my recent changes regarding title directionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 6901003: Revert my recent changes regarding title directionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: copyrights Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/external_tab_container_win.cc

diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc

index 59950d1a4ff754bc85e9dc8fed86158b5a75e4a2..c483a7845451d57d356f6d4cfb4b17866de0a168 100644

--- a/chrome/browser/external_tab_container_win.cc

+++ b/chrome/browser/external_tab_container_win.cc

@@ -884,9 +884,7 @@ bool ExternalTabContainer::InitNavigationInfo(NavigationInfo* nav_info,

tab_contents_->controller().GetCurrentEntryIndex();

nav_info->url = entry->url();

nav_info->referrer = entry->referrer();

- // TODO(evan): use directionality of title.

- // http://code.google.com/p/chromium/issues/detail?id=27094

- nav_info->title = UTF16ToWideHack(entry->title().string());

+ nav_info->title = UTF16ToWideHack(entry->title());

if (nav_info->title.empty())

nav_info->title = UTF8ToWide(nav_info->url.spec());