Move piglit to run last and reboot the machine prior.

server/site_tests/suites/control.regression

Index: server/site_tests/suites/control.regression
diff --git a/server/site_tests/suites/control.regression b/server/site_tests/suites/control.regression
index 52225cbbb4c3233bfc16bf6ec1247ab01705e3e6..4c8b9be5b46ec9eb4f62c724a2cb10b5b767156a 100644
--- a/server/site_tests/suites/control.regression
+++ b/server/site_tests/suites/control.regression
@@ -32,7 +32,6 @@ TESTS = [
   ('fsx', {}),
   ('graphics_GLAPICheck', {}),
   ('graphics_GLBench', {}),
-  ('graphics_Piglit', {}),
   ('graphics_SanAngeles', {'creds': '$backdoor'}),
   ('graphics_WindowManagerGraphicsCapture', {}),
   ('hackbench', {}),
@@ -128,14 +127,23 @@ def run_assigned_tests(machine):
   if client_attributes.has_chromeos_firmware:
     job.run_test('logging_KernelCrashServer', host=client)
 
+  #-----------------------------------------------------------------------------
+  # Tests which leave the system in a strange state below. Don't add anything to
+  # this section unless you know what you're doing.
+  #-----------------------------------------------------------------------------
+
   # This test stops tcsd which is known to cause issues with cryptohome and
   # possibly other services. Specifically, cros_ui_test based tests will fail;
   # so always run it last. See http://crosbug.com/14265
   if client_attributes.has_chromeos_firmware:
     client_at.run_test('hardware_TPMCheck')
 
+  # graphics_Piglit can crash many of the UI processes, so schedule it last and
+  # make sure the machine is in a fresh state before starting.
+  client_at.reboot()
+  client_at.run_test('graphics_Piglit')
 
-# Run server-side suites.
+# Run security suite.

[ericli, 2011/04/22 22:18:50]

so I think security test should be moved above , before line 130.

[DaleCurtis, 2011/04/22 22:25:06]

Can you chain a job.run_control inside a job.parallel_on_machines ?

On 2011/04/22 22:18:50, ericli wrote:

[ericli, 2011/04/23 01:13:19]

You r right.

I take it back,
run_control(security) actually happens even before run_assigned_tests().

LGTM

On 2011/04/22 22:25:06, dalec wrote:

 job.run_control('server/site_tests/suites/control.security')
 
 # Some of the tests in the main regression suite must be run last to prevent