Move piglit to run last and reboot the machine prior.

server/site_tests/suites/control.regression

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 AUTHOR = "Chrome OS Team"
 NAME = "Regression"
 TIME = "LONG"
 TEST_CATEGORY = "Functional"
 TEST_CLASS = "suite"
 TEST_TYPE = "server"
@@ skipping 14 matching lines @@
   ('desktopui_GTK2Config', {}),
   ('desktopui_IBusTest', {}),
   ('desktopui_ImeTest', {}),
   ('desktopui_SunSpiderBench', {}),
   ('desktopui_V8Bench', {}),
   ('desktopui_WindowManagerHotkeys', {}),
   ('disktest', {}),
   ('fsx', {}),
   ('graphics_GLAPICheck', {}),
   ('graphics_GLBench', {}),
-  ('graphics_Piglit', {}),
   ('graphics_SanAngeles', {'creds': '$backdoor'}),
   ('graphics_WindowManagerGraphicsCapture', {}),
   ('hackbench', {}),
   ('hardware_Backlight', {}),
   ('hardware_DiskSize', {}),
   ('hardware_MemoryThroughput', {'num_iteration': 1,
                                  'test_list': '18'}),
   ('hardware_MemoryTotalSize', {}),
   ('hardware_SAT', {'seconds': 20}),
   ('hardware_StorageFio', {}),
@@ skipping 75 matching lines @@
                        iface_name='hci0', tag='hci0')
   if client_attributes.has_80211n:
     client_at.run_test('network_WiFiCaps')
   if not client_attributes.has_resume_bug:
     client_at.run_test('power_Resume')
 
   job.run_test('platform_KernelErrorPaths', host=client)
   if client_attributes.has_chromeos_firmware:
     job.run_test('logging_KernelCrashServer', host=client)
 
+  #-----------------------------------------------------------------------------
+  # Tests which leave the system in a strange state below. Don't add anything to
+  # this section unless you know what you're doing.
+  #-----------------------------------------------------------------------------
+
   # This test stops tcsd which is known to cause issues with cryptohome and
   # possibly other services. Specifically, cros_ui_test based tests will fail;
   # so always run it last. See http://crosbug.com/14265
   if client_attributes.has_chromeos_firmware:
     client_at.run_test('hardware_TPMCheck')
 
+  # graphics_Piglit can crash many of the UI processes, so schedule it last and
+  # make sure the machine is in a fresh state before starting.
+  client_at.reboot()
+  client_at.run_test('graphics_Piglit')
 
-# Run server-side suites.
+# Run security suite.

[ericli, 2011/04/22 22:18:50]

so I think security test should be moved above , before line 130.

[DaleCurtis, 2011/04/22 22:25:06]

Can you chain a job.run_control inside a job.parallel_on_machines ?

On 2011/04/22 22:18:50, ericli wrote:

[ericli, 2011/04/23 01:13:19]

You r right.

I take it back,
run_control(security) actually happens even before run_assigned_tests().

LGTM

On 2011/04/22 22:25:06, dalec wrote:

 job.run_control('server/site_tests/suites/control.security')
 
 # Some of the tests in the main regression suite must be run last to prevent
 # cross-test issues. Always add new suites above this line.
 job.parallel_on_machines(run_assigned_tests, machines)