Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 6900029: Move piglit to run last and reboot the machine prior. (Closed)

Created:
9 years, 8 months ago by DaleCurtis
Modified:
9 years, 7 months ago
Reviewers:
ericli, ilja
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Move piglit to run last and reboot the machine prior. Change-Id: I4d1be86b96ebe5a7cd62b5ee50eff3a47e1eac06 BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=018d378

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M server/site_tests/suites/control.regression View 2 chunks +10 lines, -2 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
9 years, 8 months ago (2011-04-22 21:46:33 UTC) #1
ericli
http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/control.regression File server/site_tests/suites/control.regression (right): http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/control.regression#newcode146 server/site_tests/suites/control.regression:146: # Run security suite. so I think security test ...
9 years, 8 months ago (2011-04-22 22:18:50 UTC) #2
DaleCurtis
http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/control.regression File server/site_tests/suites/control.regression (right): http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/control.regression#newcode146 server/site_tests/suites/control.regression:146: # Run security suite. Can you chain a job.run_control ...
9 years, 8 months ago (2011-04-22 22:25:06 UTC) #3
ilja
Thanks for changing this! I am not qualified to review though. On 2011/04/22 22:25:06, dalec ...
9 years, 8 months ago (2011-04-22 22:45:13 UTC) #4
ericli
9 years, 8 months ago (2011-04-23 01:13:19 UTC) #5
http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/contro...
File server/site_tests/suites/control.regression (right):

http://codereview.chromium.org/6900029/diff/1/server/site_tests/suites/contro...
server/site_tests/suites/control.regression:146: # Run security suite.
You r right.

I take it back,
run_control(security) actually happens even before run_assigned_tests().

LGTM

On 2011/04/22 22:25:06, dalec wrote:
> Can you chain a job.run_control inside a job.parallel_on_machines ?
> 
> On 2011/04/22 22:18:50, ericli wrote:
> > so I think security test should be moved above , before line 130.
>

Powered by Google App Engine
This is Rietveld 408576698