Issue 6896001: Implement SetNetworkDeviceProperty() and ClearNetworkDeviceProperty().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6896001: Implement SetNetworkDeviceProperty() and ClearNetworkDeviceProperty(). (Closed)

Created:
9 years, 8 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Eric Shienbrood

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
ssh://gitrw.chromium.org:9222/cros.git@master

Visibility:
Public.

Description

Implement SetNetworkDeviceProperty() and ClearNetworkDeviceProperty(). Factor out some common code with the NetworkServiceProperty functions. BUG=None TEST=./network_property_test /device/foo SomeProperty StringValue Change-Id: Ifeb50f07e294618808bfe46e673a901a07af9463 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c53083d

Patch Set 1 #

Patch Set 2 : Fix comments and whitespace. #

Total comments: 2

Patch Set 3 : device -> device_path #

Patch Set 4 : Slight tune-up of test program #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -29 lines)			Patch
M	SConstruct.chromiumos	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos_cros_api.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos_network.h	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chromeos_network.cc	View		3 chunks	+57 lines, -28 lines	0 comments	Download
M	load.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
A	network_property_test.cc	View	1 2 3	1 chunk	+159 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Eric Shienbrood

9 years, 8 months ago (2011-04-21 21:48:26 UTC) #2

LGTM

http://codereview.chromium.org/6896001/diff/1007/chromeos_network.h
File chromeos_network.h (right):

http://codereview.chromium.org/6896001/diff/1007/chromeos_network.h#newcode141
chromeos_network.h:141: extern void (*SetNetworkDeviceProperty)(const char*
device,
silly nit: we're calling this argument device_path or service_path in the other
functions.

http://codereview.chromium.org/6896001/diff/1007/network_property_test.cc
File network_property_test.cc (right):

http://codereview.chromium.org/6896001/diff/1007/network_property_test.cc#new...
network_property_test.cc:91: // A simple program exercising the
{Set,Clear}{Device,Service}Property methods.
This is all a little bit bogus, since (a) the empty string is a legitimate
property value, distinct from a property with no value; and (b) it doesn't deal
with properties with non-string values. But I applaud the effort to add more
test programs, and it's certainly a step in the right direction.

Expand Messages | Collapse Messages