Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chromeos_network.cc

Issue 6896001: Implement SetNetworkDeviceProperty() and ClearNetworkDeviceProperty(). (Closed) Base URL: ssh://gitrw.chromium.org:9222/cros.git@master
Patch Set: Slight tune-up of test program Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos_network.h ('k') | load.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos_network.cc
diff --git a/chromeos_network.cc b/chromeos_network.cc
index afbff804479054e2ec1baee4e467b3ce7c795011..34b6dc8c7356888b294ba9193463ca4340e7237f 100644
--- a/chromeos_network.cc
+++ b/chromeos_network.cc
@@ -1916,28 +1916,9 @@ static glib::Value *ConvertToGlibValue(const ::Value* value) {
return NULL;
}
-
-extern "C"
-void ChromeOSSetNetworkServiceProperty(const char* service_path,
- const char* property,
- const ::Value* setting) {
- FlimflamCallbackData* cb_data =
- new FlimflamCallbackData(kFlimflamServiceInterface, service_path);
-
- // DEPRECATED
- // Backwards-compatibility for "CertPath=SETTINGS:key_id=1,cert_id=2,..."
- if (strcmp(property, "CertPath") == 0) {
- std::string certpath;
- if (setting->GetAsString(&certpath)) {
- // Synchronous call for backwards compatibility.
- // TODO(njw): remove once CertPath is deprecated in favor of
- // explicit EAP.* properties.
- set_certpath_properties(certpath.c_str(), cb_data->proxy.get());
- }
- delete cb_data;
- return;
- }
-
+static void SetNetworkProperty(FlimflamCallbackData *cb_data,
+ const char* property,
+ const ::Value* setting) {
// Start the DBus call. FlimflamNotifyHandleError will get called when
// it completes and log any errors.
scoped_ptr<glib::Value> gsetting(ConvertToGlibValue(setting));
@@ -1958,12 +1939,8 @@ void ChromeOSSetNetworkServiceProperty(const char* service_path,
}
}
-extern "C"
-void ChromeOSClearNetworkServiceProperty(const char* service_path,
- const char* property) {
- FlimflamCallbackData* cb_data =
- new FlimflamCallbackData(kFlimflamServiceInterface, service_path);
-
+static void ClearNetworkProperty(FlimflamCallbackData *cb_data,
+ const char* property) {
// Start the DBus call. FlimflamNotifyHandleError will get called when
// it completes and log any errors.
DBusGProxyCall* call_id = ::dbus_g_proxy_begin_call(
@@ -1981,6 +1958,58 @@ void ChromeOSClearNetworkServiceProperty(const char* service_path,
}
}
+extern "C"
+void ChromeOSSetNetworkServiceProperty(const char* service_path,
+ const char* property,
+ const ::Value* setting) {
+ FlimflamCallbackData* cb_data =
+ new FlimflamCallbackData(kFlimflamServiceInterface, service_path);
+
+ // DEPRECATED
+ // Backwards-compatibility for "CertPath=SETTINGS:key_id=1,cert_id=2,..."
+ if (strcmp(property, "CertPath") == 0) {
+ std::string certpath;
+ if (setting->GetAsString(&certpath)) {
+ // Synchronous call for backwards compatibility.
+ // TODO(njw): remove once CertPath is deprecated in favor of
+ // explicit EAP.* properties.
+ set_certpath_properties(certpath.c_str(), cb_data->proxy.get());
+ }
+ delete cb_data;
+ return;
+ }
+
+ SetNetworkProperty(cb_data, property, setting);
+}
+
+extern "C"
+void ChromeOSClearNetworkServiceProperty(const char* service_path,
+ const char* property) {
+ FlimflamCallbackData* cb_data =
+ new FlimflamCallbackData(kFlimflamServiceInterface, service_path);
+
+ ClearNetworkProperty(cb_data, property);
+}
+
+extern "C"
+void ChromeOSSetNetworkDeviceProperty(const char* device_path,
+ const char* property,
+ const ::Value* setting) {
+ FlimflamCallbackData* cb_data =
+ new FlimflamCallbackData(kFlimflamDeviceInterface, device_path);
+
+ SetNetworkProperty(cb_data, property, setting);
+}
+
+extern "C"
+void ChromeOSClearNetworkDeviceProperty(const char* device_path,
+ const char* property) {
+ FlimflamCallbackData* cb_data =
+ new FlimflamCallbackData(kFlimflamDeviceInterface, device_path);
+
+ ClearNetworkProperty(cb_data, property);
+}
+
// Cashew services
extern "C"
« no previous file with comments | « chromeos_network.h ('k') | load.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698