Issue 6895014: Avoid hidden TLS access in CpuProfiler::is_profiling().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6895014: Avoid hidden TLS access in CpuProfiler::is_profiling(). (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mikhail Naganov, mnaganov (inactive)

CC:
v8-dev

Visibility:
Public.

Avoid hidden TLS access in CpuProfiler::is_profiling(). Committed: http://code.google.com/p/v8/source/detail?r=7677

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -21 lines)			Patch
M	src/codegen.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cpu-profiler.h	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	src/cpu-profiler.cc	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Repeshko

Misha, There're two related TODOs in this file, but I want this change to be ...

9 years, 8 months ago (2011-04-22 03:01:34 UTC) #1

LGTM