src/codegen.cc - Issue 6895014: Avoid hidden TLS access in CpuProfiler::is_profiling().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen.cc

Issue 6895014: Avoid hidden TLS access in CpuProfiler::is_profiling(). (Closed)

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codegen.cc

diff --git a/src/codegen.cc b/src/codegen.cc

index 4bbe6ae26b40262a3d5610942c90d95720cd4732..6abd0e39a0783215c796d3bb993efce940fc7c62 100644

--- a/src/codegen.cc

+++ b/src/codegen.cc

@@ -176,7 +176,10 @@ static Vector<const char> kRegexp = CStrVector("regexp");

bool CodeGenerator::ShouldGenerateLog(Expression* type) {

ASSERT(type != NULL);

- if (!LOGGER->is_logging() && !CpuProfiler::is_profiling()) return false;

+ Isolate* isolate = Isolate::Current();

+ if (!isolate->logger()->is_logging() && !CpuProfiler::is_profiling(isolate)) {

+ return false;

+ }

Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle());

if (FLAG_log_regexp) {

if (name->IsEqualTo(kRegexp))

« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »