Issue 6893093: Fix assert in KeyedLoadIC constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6893093: Fix assert in KeyedLoadIC constructor (Closed)

Created:
9 years, 8 months ago by danno

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix assert in KeyedLoadIC constructor Don't assert when external array ICs are also handled by the KeyedLoadIC. BUG=1346 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7712

Patch Set 1 : fix 1346 #

Patch Set 2 : Fix assert #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/ic.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM Have you checked other occurrences of is_keyed_load_stub? I wonder if we should let all ...

9 years, 8 months ago (2011-04-28 14:20:42 UTC) #2

danno

9 years, 8 months ago (2011-04-28 19:45:46 UTC) #3

I did briefly check other occurrences, and I think it's ok for now. I'm changing
the classification of external arrays anyway for the polymorphic cache CL that
I'm working on, since to be able to easily and consistently find the monomorphic
stub for a receiver, it should act more like the KeyedLoadICs.

Expand Messages | Collapse Messages