Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: src/ic.h

Issue 6893093: Fix assert in KeyedLoadIC constructor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix assert Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 320
321 static void Clear(Address address, Code* target); 321 static void Clear(Address address, Code* target);
322 322
323 friend class IC; 323 friend class IC;
324 }; 324 };
325 325
326 326
327 class KeyedLoadIC: public IC { 327 class KeyedLoadIC: public IC {
328 public: 328 public:
329 explicit KeyedLoadIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) { 329 explicit KeyedLoadIC(Isolate* isolate) : IC(NO_EXTRA_FRAME, isolate) {
330 ASSERT(target()->is_keyed_load_stub()); 330 ASSERT(target()->is_keyed_load_stub() ||
331 target()->is_external_array_load_stub());
331 } 332 }
332 333
333 MUST_USE_RESULT MaybeObject* Load(State state, 334 MUST_USE_RESULT MaybeObject* Load(State state,
334 Handle<Object> object, 335 Handle<Object> object,
335 Handle<Object> key); 336 Handle<Object> key);
336 337
337 // Code generator routines. 338 // Code generator routines.
338 static void GenerateMiss(MacroAssembler* masm); 339 static void GenerateMiss(MacroAssembler* masm);
339 static void GenerateRuntimeGetProperty(MacroAssembler* masm); 340 static void GenerateRuntimeGetProperty(MacroAssembler* masm);
340 static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); } 341 static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); }
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 596
596 Token::Value op_; 597 Token::Value op_;
597 }; 598 };
598 599
599 // Helper for TRBinaryOpIC and CompareIC. 600 // Helper for TRBinaryOpIC and CompareIC.
600 void PatchInlinedSmiCode(Address address); 601 void PatchInlinedSmiCode(Address address);
601 602
602 } } // namespace v8::internal 603 } } // namespace v8::internal
603 604
604 #endif // V8_IC_H_ 605 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698