Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 6883299: Hide translate infobar on programmatic navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update testcase. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index bf511cf18d0f8702825585968ddc237390181c9f..2206b9f2c2103d720ecf89f913f980c97d31f8d4 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1207,12 +1207,6 @@ void TabContents::SetIsLoading(bool is_loading,
void TabContents::ExpireInfoBars(
const NavigationController::LoadCommittedDetails& details) {
- // Only hide InfoBars when the user has done something that makes the main
- // frame load. We don't want various automatic or subframe navigations making
- // it disappear.
- if (!details.is_user_initiated_main_frame_load())
- return;
-
// NOTE: It is not safe to change the following code to count upwards or use
// iterators, as the RemoveInfoBar() call synchronously modifies our delegate
// list.

Powered by Google App Engine
This is Rietveld 408576698