chrome/browser/ui/cocoa/keystone_infobar.mm - Issue 6883299: Hide translate infobar on programmatic navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/keystone_infobar.mm

Issue 6883299: Hide translate infobar on programmatic navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update testcase. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/keystone_infobar.mm

diff --git a/chrome/browser/ui/cocoa/keystone_infobar.mm b/chrome/browser/ui/cocoa/keystone_infobar.mm

index 265d122400a1473fdf1b65513fe8abaa90f5e7b3..fb783f81b7cb22b2af6e33171f6db987ba5a1562 100644

--- a/chrome/browser/ui/cocoa/keystone_infobar.mm

+++ b/chrome/browser/ui/cocoa/keystone_infobar.mm

@@ -84,7 +84,7 @@ KeystonePromotionInfoBarDelegate::~KeystonePromotionInfoBarDelegate() {

bool KeystonePromotionInfoBarDelegate::ShouldExpire(

const NavigationController::LoadCommittedDetails& details) const {

- return can_expire_;

+ return details.is_user_initiated_main_frame_load() && can_expire_;

}

gfx::Image* KeystonePromotionInfoBarDelegate::GetIcon() const {