Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 6883231: Start working on removing those .la files en masse. (Closed)

Created:
9 years, 8 months ago by Flameeyes-Gentoo
Modified:
9 years ago
Reviewers:
petkov, raymes
CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush
Visibility:
Public.

Description

Start working on removing those .la files en masse. Change-Id: I25d7eb61d968f90f03e0a2b78318093f952373b6 R=raymes BUG=none TEST=./make_chroot, ./setup_board, ./build_packages, ./build_image

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chromeos/config/make.conf.amd64-host View 1 chunk +19 lines, -0 lines 0 comments Download
M chromeos/config/make.conf.common-target View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Flameeyes-Gentoo
9 years, 8 months ago (2011-04-28 17:25:00 UTC) #1
petkov
Is this INSTALL_MASK in addition to the DEFAULT_INSTALL_MASK defined in common.sh and used in build_image?
9 years, 8 months ago (2011-04-28 18:39:38 UTC) #2
Flameeyes-Gentoo
Il giorno gio, 28/04/2011 alle 18.39 +0000, petkov@chromium.org ha scritto: > Is this INSTALL_MASK in ...
9 years, 8 months ago (2011-04-28 20:55:33 UTC) #3
petkov
On 2011/04/28 20:55:33, Flameeyes-Gentoo wrote: > Il giorno gio, 28/04/2011 alle 18.39 +0000, mailto:petkov@chromium.org ha ...
9 years, 8 months ago (2011-04-28 21:08:01 UTC) #4
petkov
On 2011/04/28 21:08:01, petkov wrote: > On 2011/04/28 20:55:33, Flameeyes-Gentoo wrote: > > Il giorno ...
9 years, 8 months ago (2011-04-28 21:08:28 UTC) #5
Flameeyes-Gentoo
Il giorno gio, 28/04/2011 alle 21.08 +0000, petkov@chromium.org ha scritto: > > I'm just confused ...
9 years, 8 months ago (2011-04-28 21:19:25 UTC) #6
petkov
On 2011/04/28 21:19:25, Flameeyes-Gentoo wrote: > Il giorno gio, 28/04/2011 alle 21.08 +0000, mailto:petkov@chromium.org ha ...
9 years, 8 months ago (2011-04-28 22:39:38 UTC) #7
raymes
9 years, 7 months ago (2011-05-02 21:30:26 UTC) #8
LGTM

On Thu, Apr 28, 2011 at 3:39 PM,  <petkov@chromium.org> wrote:
> On 2011/04/28 21:19:25, Flameeyes-Gentoo wrote:
>>
>> Il giorno gio, 28/04/2011 alle 21.08 +0000, mailto:petkov@chromium.org ha
>> scritto:
>> >
>> > I'm just confused why you need to mask all these .la files
>> > individually when
>> > they should be masked already by the global *.la mask.
>> >
>> >
>
>> Because they need to be removed during the build process or they hinder
>> cross-compilation.
>
> Got it. As long as the mask doesn't override the default mask, the change is
> fine by me then.
>
>
>> --
>> Diego Elio Pettenò — Flameeyes
>> http://blog.flameeyes.eu/
>
>
>
> http://codereview.chromium.org/6883231/
>

Powered by Google App Engine
This is Rietveld 408576698