Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 6883173: Enable building base.dll for the multi-dll build. (Closed)

Created:
9 years, 8 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable building base.dll for the multi-dll build. BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83186

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M base/base.gypi View 2 chunks +21 lines, -1 line 0 comments Download
M build/common.gypi View 2 chunks +3 lines, -1 line 4 comments Download

Messages

Total messages: 5 (0 generated)
rvargas (doing something else)
9 years, 8 months ago (2011-04-26 23:04:40 UTC) #1
rvargas (doing something else)
http://codereview.chromium.org/6883173/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/6883173/diff/1/build/common.gypi#newcode1558 build/common.gypi:1558: 'shlwapi.lib', I should be able to add #pragma comment(lib) ...
9 years, 8 months ago (2011-04-26 23:10:52 UTC) #2
brettw
http://codereview.chromium.org/6883173/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/6883173/diff/1/build/common.gypi#newcode1558 build/common.gypi:1558: 'shlwapi.lib', These are things that base depends on, though, ...
9 years, 8 months ago (2011-04-26 23:53:59 UTC) #3
rvargas (doing something else)
http://codereview.chromium.org/6883173/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/6883173/diff/1/build/common.gypi#newcode1558 build/common.gypi:1558: 'shlwapi.lib', On 2011/04/26 23:53:59, brettw wrote: > These are ...
9 years, 8 months ago (2011-04-27 00:18:18 UTC) #4
brettw
9 years, 8 months ago (2011-04-27 18:11:07 UTC) #5
LGTM

http://codereview.chromium.org/6883173/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/6883173/diff/1/build/common.gypi#newcode1558
build/common.gypi:1558: 'shlwapi.lib',
Okay, makes sense.

Powered by Google App Engine
This is Rietveld 408576698