Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3272)

Unified Diff: base/base.gypi

Issue 6883173: Enable building base.dll for the multi-dll build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gypi
===================================================================
--- base/base.gypi (revision 83082)
+++ base/base.gypi (working copy)
@@ -422,7 +422,7 @@
'targets': [
{
'target_name': 'base',
- 'type': '<(library)',
+ 'type': '<(component)',
'msvs_guid': '1832A374-8A74-4F9E-B536-69A699B3E165',
'variables': {
'base_target': 1,
@@ -527,6 +527,26 @@
'win_util.cc',
],
},],
+ [ 'OS=="win" and component=="shared_library"', {
+ 'defines': [
+ 'BASE_DLL',
+ 'BASE_IMPLEMENTATION=1',
+ ],
+ 'msvs_disabled_warnings': [
+ 4251,
+ ],
+ 'sources!': [
+ 'debug/debug_on_start_win.cc',
+ ],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'BASE_DLL',
+ ],
+ 'msvs_disabled_warnings': [
+ 4251,
+ ],
+ },
+ }],
],
'sources': [
'third_party/nspr/prcpucfg.h',
« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698