Issue 6883142: Show ChromeOS bios firmware in about dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883142: Show ChromeOS bios firmware in about dialog. (Closed)

Created:
9 years, 8 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Show ChromeOS bios firmware in about dialog. BUG=chromium-os:13692 TEST=version_loader_unittest. load about dialog and verify that the bios firmware is shown right away and also when you click "More info". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82932

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -3 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.h	View	5 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/version_loader.cc	View	6 chunks	+66 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader_unittest.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/about_page.html	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/about_page.js	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM