Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: chrome/browser/chromeos/version_loader_unittest.cc

Issue 6883142: Show ChromeOS bios firmware in about dialog. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/version_loader.cc ('k') | chrome/browser/resources/options/about_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/version_loader_unittest.cc
===================================================================
--- chrome/browser/chromeos/version_loader_unittest.cc (revision 82505)
+++ chrome/browser/chromeos/version_loader_unittest.cc (working copy)
@@ -25,6 +25,13 @@
static const char kTest8[] = "CHROMEOS_RELEASE_VERSION=\"0.2.3.3\"";
static const char kTest9[] = "CHROMEOS_RELEASE_VERSION=\"\"";
+static const char kTest10[] = "vendor | FOO";
+static const char kTest11[] = "firmware | FOO";
+static const char kTest12[] = "firmware | FOO";
+static const char kTest13[] = "version | 0.2.3.3";
+static const char kTest14[] = "version | 0.2.3.3";
+static const char kTest15[] = "version 0.2.3.3";
+
TEST_F(VersionLoaderTest, ParseFullVersion) {
EXPECT_EQ("0.2.3.3",
VersionLoader::ParseVersion(kTest1,
@@ -61,4 +68,13 @@
VersionLoader::kFullVersionPrefix));
}
+TEST_F(VersionLoaderTest, ParseFirmware) {
+ EXPECT_EQ(std::string(), VersionLoader::ParseFirmware(kTest10));
+ EXPECT_EQ(std::string(), VersionLoader::ParseFirmware(kTest11));
+ EXPECT_EQ(std::string(), VersionLoader::ParseFirmware(kTest12));
+ EXPECT_EQ("0.2.3.3", VersionLoader::ParseFirmware(kTest13));
+ EXPECT_EQ("0.2.3.3", VersionLoader::ParseFirmware(kTest14));
+ EXPECT_EQ("0.2.3.3", VersionLoader::ParseFirmware(kTest15));
+}
+
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/version_loader.cc ('k') | chrome/browser/resources/options/about_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698