Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: net/url_request/url_request_job.cc

Issue 6881106: Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment & decreased logging verbosity. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_stream_parser.cc ('K') | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 3073414d421426aa7e3b086300840e6069007db1..b8f26910f505dfce54f2fe689b7422cf20a3f928 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -306,7 +306,7 @@ void URLRequestJob::NotifyReadComplete(int bytes_read) {
return;
// When notifying the delegate, the delegate can release the request
- // (and thus release 'this'). After calling to the delgate, we must
+ // (and thus release 'this'). After calling to the delegate, we must
// check the request pointer to see if it still exists, and return
// immediately if it has been destroyed. self_preservation ensures our
// survival until we can get out of this method.
@@ -327,6 +327,10 @@ void URLRequestJob::NotifyReadComplete(int bytes_read) {
postfilter_bytes_read_ += bytes_read;
request_->delegate()->OnReadCompleted(request_, bytes_read);
}
+ VLOG(20) << __FUNCTION__ << "() "
darin (slow to review) 2011/05/16 17:47:16 would it be more helpful if this were output to th
ahendrickson 2011/05/16 19:37:40 I find it useful to use VLOG, as I have a lot of o
+ << "\"" << (request_ ? request_->url().spec() : "???") << "\""
+ << " bytes read = " << bytes_read
+ << " total = " << postfilter_bytes_read_;
}
void URLRequestJob::NotifyStartError(const URLRequestStatus &status) {
« net/http/http_stream_parser.cc ('K') | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698