Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads.

net/url_request/url_request_job.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_job.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
@@ skipping 288 matching lines @@
   // The headers should be complete before reads complete
   DCHECK(has_handled_response_);
 
   OnRawReadComplete(bytes_read);
 
   // Don't notify if we had an error.
   if (!request_->status().is_success())
     return;
 
   // When notifying the delegate, the delegate can release the request
-  // (and thus release 'this').  After calling to the delgate, we must
+  // (and thus release 'this').  After calling to the delegate, we must
   // check the request pointer to see if it still exists, and return
   // immediately if it has been destroyed.  self_preservation ensures our
   // survival until we can get out of this method.
   scoped_refptr<URLRequestJob> self_preservation(this);
 
   prefilter_bytes_read_ += bytes_read;
   if (filter_.get()) {
     // Tell the filter that it has more data
     FilteredDataRead(bytes_read);
 
     // Filter the data.
     int filter_bytes_read = 0;
     if (ReadFilteredData(&filter_bytes_read)) {
       postfilter_bytes_read_ += filter_bytes_read;
       request_->delegate()->OnReadCompleted(request_, filter_bytes_read);
     }
   } else {
     postfilter_bytes_read_ += bytes_read;
     request_->delegate()->OnReadCompleted(request_, bytes_read);
   }
+  VLOG(20) << __FUNCTION__ << "() "

[darin (slow to review), 2011/05/16 17:47:16]

would it be more helpful if this were output to the net log instead?  same goes
for other VLOGs.

[ahendrickson, 2011/05/16 19:37:40]

I find it useful to use VLOG, as I have a lot of other debugging information
that uses it (which is not appropriate for net-internals).  This way I don't
have to search in two different locations for the information I want, and it's
serial in time).

I can add a net-internals log statement if you think it would be useful.

+           << "\"" << (request_ ? request_->url().spec() : "???") << "\""
+           << " bytes read = " << bytes_read
+           << " total = " << postfilter_bytes_read_;
 }
 
 void URLRequestJob::NotifyStartError(const URLRequestStatus &status) {
   DCHECK(!has_handled_response_);
   has_handled_response_ = true;
   if (request_) {
     request_->set_status(status);
     request_->ResponseStarted();
   }
 }
@@ skipping 261 matching lines @@
 }
 
 bool URLRequestJob::FilterHasData() {
     return filter_.get() && filter_->stream_data_len();
 }
 
 void URLRequestJob::UpdatePacketReadTimes() {
 }
 
 }  // namespace net