Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 6881073: Cleanup popup related browser navigation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and merge with avi's popup block changes. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/common/content_settings_types.h" 9 #include "chrome/common/content_settings_types.h"
10 #include "content/browser/tab_contents/navigation_entry.h" 10 #include "content/browser/tab_contents/navigation_entry.h"
11 #include "ui/gfx/native_widget_types.h" 11 #include "ui/gfx/native_widget_types.h"
12 #include "webkit/glue/window_open_disposition.h"
12 13
13 class Browser; 14 class Browser;
14 class BrowserWindowTesting; 15 class BrowserWindowTesting;
15 class DownloadShelf; 16 class DownloadShelf;
16 class FindBar; 17 class FindBar;
17 class GURL; 18 class GURL;
18 class HtmlDialogUIDelegate; 19 class HtmlDialogUIDelegate;
19 class LocationBar; 20 class LocationBar;
20 class Panel; 21 class Panel;
21 class Profile; 22 class Profile;
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 320
320 // Invoked when the instant's tab contents should be hidden. 321 // Invoked when the instant's tab contents should be hidden.
321 // |instant_is_active| indicates if instant is still active. 322 // |instant_is_active| indicates if instant is still active.
322 virtual void HideInstant(bool instant_is_active) = 0; 323 virtual void HideInstant(bool instant_is_active) = 0;
323 324
324 // Returns the desired bounds for instant in screen coordinates. Note that if 325 // Returns the desired bounds for instant in screen coordinates. Note that if
325 // instant isn't currently visible this returns the bounds instant would be 326 // instant isn't currently visible this returns the bounds instant would be
326 // placed at. 327 // placed at.
327 virtual gfx::Rect GetInstantBounds() = 0; 328 virtual gfx::Rect GetInstantBounds() = 0;
328 329
330 // Return the correct disposition for a popup window based on |bounds|.
331 virtual WindowOpenDisposition GetDispositionForPopupBounds(
332 const gfx::Rect& bounds) = 0;
333
329 #if defined(OS_CHROMEOS) 334 #if defined(OS_CHROMEOS)
330 // Shows the keyboard overlay dialog box. 335 // Shows the keyboard overlay dialog box.
331 virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0; 336 virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0;
332 #endif 337 #endif
333 338
334 // Construct a BrowserWindow implementation for the specified |browser|. 339 // Construct a BrowserWindow implementation for the specified |browser|.
335 static BrowserWindow* CreateBrowserWindow(Browser* browser); 340 static BrowserWindow* CreateBrowserWindow(Browser* browser);
336 341
337 // Construct a FindBar implementation for the specified |browser|. 342 // Construct a FindBar implementation for the specified |browser|.
338 static FindBar* CreateFindBar(Browser* browser_window); 343 static FindBar* CreateFindBar(Browser* browser_window);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 376
372 // Returns the ToolbarView. 377 // Returns the ToolbarView.
373 virtual ToolbarView* GetToolbarView() const = 0; 378 virtual ToolbarView* GetToolbarView() const = 0;
374 #endif 379 #endif
375 380
376 protected: 381 protected:
377 virtual ~BrowserWindowTesting() {} 382 virtual ~BrowserWindowTesting() {}
378 }; 383 };
379 384
380 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 385 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698