Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 6881008: Fix drover regression introduced in r80453. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jianli
Visibility:
Public.

Description

Fix drover regression introduced in r80453. getSVNInfo() is expected to fail in some use case. Make this behavior explicit. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M drover.py View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-18 14:08:05 UTC) #1
Dirk Pranke
9 years, 8 months ago (2011-04-18 18:40:03 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698