Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2940)

Unified Diff: drover.py

Issue 6881008: Fix drover regression introduced in r80453. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drover.py
diff --git a/drover.py b/drover.py
index 17aa49a381a3258906d4e7d29e7bc562a394b57a..6ffef859496af0ce9b4cfb80e3e66cbe7c11ba12 100755
--- a/drover.py
+++ b/drover.py
@@ -64,14 +64,16 @@ def gclUpload(revision, author):
return runGcl(command)
def getSVNInfo(url, revision):
- svn_info = subprocess2.check_output(
- ['svn', 'info', '%s@%s' % (url, revision)]).splitlines()
info = {}
- for line in svn_info:
- match = re.search(r"(.*?):(.*)", line)
- if match:
- info[match.group(1).strip()]=match.group(2).strip()
-
+ try:
+ svn_info = subprocess2.check_output(
+ ['svn', 'info', '%s@%s' % (url, revision)]).splitlines()
+ for line in svn_info:
+ match = re.search(r"(.*?):(.*)", line)
+ if match:
+ info[match.group(1).strip()] = match.group(2).strip()
+ except subprocess2.CalledProcessError:
+ pass
return info
def isSVNDirty():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698