Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 6880339: Small cosmetic change - simplify retry logic (Closed)

Created:
9 years, 7 months ago by khim
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Small cosmetic change - simplify retry logic We can avoid redundant variables if we'll use standard python's try-retry-fail construct. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M build/download_utils.py View 1 chunk +8 lines, -3 lines 0 comments Download
M build/http_download.py View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
khim
9 years, 7 months ago (2011-05-01 08:05:59 UTC) #1
noelallen_use_chromium
9 years, 7 months ago (2011-05-04 23:49:33 UTC) #2
The change looks fine, but I'm not sure the comment makes sense.  The change
appears to raise instead of continue, in one re-try case (the other had it
already), and to explicitly print a FAILED message after 5 retries instead of
just implying it.

Not sure what you mean by redundant variable.  Otherwise,
LGTM

Powered by Google App Engine
This is Rietveld 408576698