Small cosmetic change - simplify retry logic

build/http_download.py

 #!/usr/bin/python2.4
 # Copyright 2009, Google Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 54 matching lines @@
     if password:
       auth_code = base64.b64encode(username + ':' + password)
     else:
       auth_code = base64.b64encode(username)
     headers.append(('Authorization', 'Basic ' + auth_code))
   opener = urllib2.build_opener()
   opener.addheaders = headers
   urllib2.install_opener(opener)
   _CreateDirectory(os.path.split(target)[0])
   # Retry up to 10 times (appengine logger is flaky).
-  retries = 10
-  for i in range(retries):
+  for i in xrange(10):
+    if i:
+      sys.stdout.write('Download failed on %s, retrying... (%d)\n' % (url, i))
     try:
       src = urllib2.urlopen(url)
       try:
         download_utils.WriteDataFromStream(target, src, chunk_size=2**20,
                                            verbose=verbose)
       finally:
         src.close()
       break
     except urllib2.HTTPError:
-      if i < retries - 1:
-        sys.stdout.write('Download failed on %s, retrying... (%d)\n' % (url, i))
-        continue
-      sys.stdout.write('Download failed on %s, giving up.\n' % url)
-      raise
+      pass
+  else:
+    sys.stdout.write('Download failed on %s, giving up.\n' % url)
+    raise