Issue 6880238: Atomic ops: put the CPU features struct in v8::internal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880238: Atomic ops: put the CPU features struct in v8::internal. (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Atomic ops: put the CPU features struct in v8::internal. Committed: http://code.google.com/p/v8/source/detail?r=7695

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	src/atomicops_internals_x86_gcc.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	src/atomicops_internals_x86_gcc.cc	View		3 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

If nobody outside the module uses it, you might want to put the whole thing ...

9 years, 8 months ago (2011-04-27 17:01:48 UTC) #2

Vitaly Repeshko

9 years, 8 months ago (2011-04-27 17:10:05 UTC) #4

On 2011/04/27 17:01:48, Evan Martin wrote:
> If nobody outside the module uses it, you might want to put the whole thing
> inside the .cc file in an anon namespace.  I don't really have a lot of
context
> on this code, though.  (Chrome seems to have a copy of it in base/ for some
> reason...)

It has to be expose because it's used in inline functions.

Expand Messages | Collapse Messages