Issue 6880204: Refactor lithium classes to reduce the number of virtual functions.

Issue 6880204: Refactor lithium classes to reduce the number of virtual functions. (Closed)

Created:
9 years, 8 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor lithium classes to reduce the number of virtual functions. This reduces the binary size by making the Is* type-test functions non-virtual. I had to change Gap and Label instructions to have a common abstract superclass because both act as gap-instructions for the register allocator. Committed: http://code.google.com/p/v8/source/detail?r=7691

Patch Set 1 #

Patch Set 2 : fixed lints #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -74 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2	10 chunks	+44 lines, -20 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2	11 chunks	+44 lines, -28 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2	10 chunks	+43 lines, -19 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fschneider

This is ia32 only. I'll port to the other platforms once this is reviewed.

9 years, 8 months ago (2011-04-26 14:55:38 UTC) #1

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6880204/diff/4002/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/6880204/diff/4002/src/ia32/lithium-ia32.h#newcode201 src/ia32/lithium-ia32.h:201: #define DECLARE_OPCODE(type) k##type, I guess we usually write ...

9 years, 8 months ago (2011-04-26 15:06:53 UTC) #2

fschneider

Ported to x64 and arm. (same as ia32) Please have another quick look.

9 years, 8 months ago (2011-04-27 08:58:41 UTC) #3

LGTM.

Expand Messages | Collapse Messages