Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6880204: Refactor lithium classes to reduce the number of virtual functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 682
683 683
684 void LCodeGen::DoLabel(LLabel* label) { 684 void LCodeGen::DoLabel(LLabel* label) {
685 if (label->is_loop_header()) { 685 if (label->is_loop_header()) {
686 Comment(";;; B%d - LOOP entry", label->block_id()); 686 Comment(";;; B%d - LOOP entry", label->block_id());
687 } else { 687 } else {
688 Comment(";;; B%d", label->block_id()); 688 Comment(";;; B%d", label->block_id());
689 } 689 }
690 __ bind(label->label()); 690 __ bind(label->label());
691 current_block_ = label->block_id(); 691 current_block_ = label->block_id();
692 LCodeGen::DoGap(label); 692 DoGap(label);
693 } 693 }
694 694
695 695
696 void LCodeGen::DoParallelMove(LParallelMove* move) { 696 void LCodeGen::DoParallelMove(LParallelMove* move) {
697 resolver_.Resolve(move); 697 resolver_.Resolve(move);
698 } 698 }
699 699
700 700
701 void LCodeGen::DoGap(LGap* gap) { 701 void LCodeGen::DoGap(LGap* gap) {
702 for (int i = LGap::FIRST_INNER_POSITION; 702 for (int i = LGap::FIRST_INNER_POSITION;
703 i <= LGap::LAST_INNER_POSITION; 703 i <= LGap::LAST_INNER_POSITION;
704 i++) { 704 i++) {
705 LGap::InnerPosition inner_pos = static_cast<LGap::InnerPosition>(i); 705 LGap::InnerPosition inner_pos = static_cast<LGap::InnerPosition>(i);
706 LParallelMove* move = gap->GetParallelMove(inner_pos); 706 LParallelMove* move = gap->GetParallelMove(inner_pos);
707 if (move != NULL) DoParallelMove(move); 707 if (move != NULL) DoParallelMove(move);
708 } 708 }
709 709
710 LInstruction* next = GetNextInstruction(); 710 LInstruction* next = GetNextInstruction();
711 if (next != NULL && next->IsLazyBailout()) { 711 if (next != NULL && next->IsLazyBailout()) {
712 int pc = masm()->pc_offset(); 712 int pc = masm()->pc_offset();
713 safepoints_.SetPcAfterGap(pc); 713 safepoints_.SetPcAfterGap(pc);
714 } 714 }
715 } 715 }
716 716
717 717
718 void LCodeGen::DoInstructionGap(LInstructionGap* instr) {
719 DoGap(instr);
720 }
721
722
718 void LCodeGen::DoParameter(LParameter* instr) { 723 void LCodeGen::DoParameter(LParameter* instr) {
719 // Nothing to do. 724 // Nothing to do.
720 } 725 }
721 726
722 727
723 void LCodeGen::DoCallStub(LCallStub* instr) { 728 void LCodeGen::DoCallStub(LCallStub* instr) {
724 ASSERT(ToRegister(instr->context()).is(esi)); 729 ASSERT(ToRegister(instr->context()).is(esi));
725 ASSERT(ToRegister(instr->result()).is(eax)); 730 ASSERT(ToRegister(instr->result()).is(eax));
726 switch (instr->hydrogen()->major_key()) { 731 switch (instr->hydrogen()->major_key()) {
727 case CodeStub::RegExpConstructResult: { 732 case CodeStub::RegExpConstructResult: {
(...skipping 3488 matching lines...) Expand 10 before | Expand all | Expand 10 after
4216 ASSERT(osr_pc_offset_ == -1); 4221 ASSERT(osr_pc_offset_ == -1);
4217 osr_pc_offset_ = masm()->pc_offset(); 4222 osr_pc_offset_ = masm()->pc_offset();
4218 } 4223 }
4219 4224
4220 4225
4221 #undef __ 4226 #undef __
4222 4227
4223 } } // namespace v8::internal 4228 } } // namespace v8::internal
4224 4229
4225 #endif // V8_TARGET_ARCH_IA32 4230 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698