Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: views/view.h

Issue 6880201: Scrap WNDCLASSEX.hCursor, update GetCursorForPoint, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nix WindowWin cursors; only SetCuror on client events; add RootView::UpdateCursor Win arrow default. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/view.h
diff --git a/views/view.h b/views/view.h
index 8fe4de8656cf9a39ebd9cbe70b600260254e977f..a41988d4828aa9aa7797a7dedafe057405948747 100644
--- a/views/view.h
+++ b/views/view.h
@@ -583,12 +583,11 @@ class View : public AcceleratorTarget {
// Returns the deepest visible descendant that contains the specified point.
virtual View* GetEventHandlerForPoint(const gfx::Point& point);
- // Return the cursor that should be used for this view or NULL if
Peter Kasting 2011/04/27 00:22:12 Nit: This still can return NULL in some cases. Sh
msw 2011/04/27 01:58:03 With native cursor types, NULL should be used expl
- // the default cursor should be used. The provided point is in the
- // receiver's coordinate system. The caller is responsible for managing the
- // lifetime of the returned object, though that lifetime may vary from
- // platform to platform. On Windows, the cursor is a shared resource but in
- // Gtk, the framework destroys the returned cursor after setting it.
+ // Return the cursor that should be used for this view or the default cursor.
+ // The provided point is in the receiver's coordinate system. The caller is
+ // responsible for managing the lifetime of the returned object, though that
+ // lifetime may vary from platform to platform. On Windows, the cursor is a
+ //shared resource but Gtk destroys the returned cursor after setting it.
Peter Kasting 2011/04/27 00:22:12 Nit: Initial space; comma after "resource"
msw 2011/04/27 01:58:03 Done.
virtual gfx::NativeCursor GetCursorForPoint(ui::EventType event_type,
const gfx::Point& p);

Powered by Google App Engine
This is Rietveld 408576698