Scrap WNDCLASSEX.hCursor, update GetCursorForPoint, etc.

views/view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_VIEW_H_
 #define VIEWS_VIEW_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 565 matching lines @@
   // Enable/Disable accelerated compositing.
   static void set_use_acceleration_when_possible(bool use);
 
   // Input ---------------------------------------------------------------------
   // The points (and mouse locations) in the following functions are in the
   // view's coordinates, except for a RootView.
 
   // Returns the deepest visible descendant that contains the specified point.
   virtual View* GetEventHandlerForPoint(const gfx::Point& point);
 
-  // Return the cursor that should be used for this view or NULL if

[Peter Kasting, 2011/04/27 00:22:12]

Nit: This still can return NULL in some cases.  Should this sentence have been
left as-is?

[msw, 2011/04/27 01:58:03]

With native cursor types, NULL should be used explicitly to mean:
WIN: "the cursor is removed from the screen"
http://msdn.microsoft.com/en-us/library/ms648393(v=vs.85).aspx
GDK: "use the cursor of its parent window"
http://developer.gnome.org/gdk/stable/gdk-Windows.html#gdk-window-set-cursor

I nixed the behavior that replaced NULL with default/|previous_cursor_| from
WidgetWin, and WidgetGtk seemingly already uses the native behavior.

We ought to eventually create a cross platform cursor type/enum.

-  // the default cursor should be used. The provided point is in the
-  // receiver's coordinate system. The caller is responsible for managing the
-  // lifetime of the returned object, though that lifetime may vary from
-  // platform to platform. On Windows, the cursor is a shared resource but in
-  // Gtk, the framework destroys the returned cursor after setting it.
+  // Return the cursor that should be used for this view or the default cursor.
+  // The provided point is in the receiver's coordinate system. The caller is
+  // responsible for managing the lifetime of the returned object, though that
+  // lifetime may vary from platform to platform. On Windows, the cursor is a
+  //shared resource but Gtk destroys the returned cursor after setting it.

[Peter Kasting, 2011/04/27 00:22:12]

Nit: Initial space; comma after "resource"

[msw, 2011/04/27 01:58:03]

Done.

   virtual gfx::NativeCursor GetCursorForPoint(ui::EventType event_type,
                                               const gfx::Point& p);
 
   // Convenience to test whether a point is within this view's bounds
   virtual bool HitTest(const gfx::Point& l) const;
 
   // This method is invoked when the user clicks on this view.
   // The provided event is in the receiver's coordinate system.
   //
   // Return true if you processed the event and want to receive subsequent
@@ skipping 808 matching lines @@
   // The Windows-specific accessibility implementation for this View.
   scoped_refptr<NativeViewAccessibilityWin> native_view_accessibility_win_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_VIEW_H_